Feat: Polkadot v1.12 to v1.14 upgrade#454
Closed
Aideepakchaudhary wants to merge 19 commits intofeat/polkadot-v1.12.0-upgradefrom
Closed
Feat: Polkadot v1.12 to v1.14 upgrade#454Aideepakchaudhary wants to merge 19 commits intofeat/polkadot-v1.12.0-upgradefrom
Aideepakchaudhary wants to merge 19 commits intofeat/polkadot-v1.12.0-upgradefrom
Conversation
…nto feat/polkadot-v1.14.0-upgrade # Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # pallets/ddc-clusters-gov/src/mock.rs # runtime/cere-dev/src/lib.rs # runtime/cere/src/lib.rs
ayushmishra2005
suggested changes
Oct 23, 2024
Contributor
ayushmishra2005
left a comment
ayushmishra2005
left a comment
There was a problem hiding this comment.
@Aideepakchaudhary Please make sure, this comment is addressed in this PR.
ayushmishra2005
suggested changes
Nov 6, 2024
| @@ -44,20 +43,13 @@ parameter_types! { | |||
|
|
|||
| #[derive_impl(frame_system::config_preludes::TestDefaultConfig)] | |||
| impl frame_system::Config for Test { | |||
Contributor
There was a problem hiding this comment.
@Aideepakchaudhary A lot of cleanup was done as a part of paritytech/polkadot-sdk#4642
Please apply changes in all mock.rs.
runtime/cere-dev/src/lib.rs
Outdated
| type MaximumReasonLength = MaximumReasonLength; | ||
| type WeightInfo = pallet_bounties::weights::SubstrateWeight<Runtime>; | ||
| type ChildBountyManager = ChildBounties; | ||
| type OnSlash = (); |
Contributor
There was a problem hiding this comment.
Shouldn't be Treasury?
Contributor
There was a problem hiding this comment.
please do the same for cere runtime.
ayushmishra2005
suggested changes
Nov 6, 2024
Contributor
ayushmishra2005
left a comment
ayushmishra2005
left a comment
There was a problem hiding this comment.
@Aideepakchaudhary
Please update MaxFreezes value according to paritytech/polkadot-sdk#4615
- type MaxFreezes = ConstU32<1>;
+ type MaxFreezes = VariantCountOf<RuntimeFreezeReason>;
ayushmishra2005
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is upgrading Runtime's and Node's dependencies from Polkadot-SDK release
v1.12.0to1.14.0Notes
Relevant upgrade's notes and comments.
Integrate
builderfn in chain spec file.Potential Breaking changes
Considerationtrait generic overFootprintand indicates zero cost paritytech/polkadot-sdk#4596]: Frame: Consideration trait generic over Footprint and handles zero costruntimemacro paritytech/polkadot-sdk#4769]: Use real rust type for pallet alias in runtime macroKindly refer to the official Polkadot release report for further details: Polkadot v1.14.0
Polkadot release analysis: Polkadot v1.14.0 analysis
Process
spec_verfor bothtestnetandmainnetRuntime.TBDCodebase Upgrade Acceptance Criteria
cargo checkpassescargo testpassescargo buildon-- releaseprofile correctly buildstry-runtimeandruntime-benchmarksfeatures compileblock-productionconfig file generates blocks.Runtime & Node Upgrade Acceptance Criteria
Runtime upgrade works on Zombienet
Node upgrade works on Zombienet
Runtime upgrade works on Chopsticks
Try-runtime passes with no pending migrations
<!--- PR TEMPLATE CONTENT STARTS HERE -->
Types of Changes
Please select the branch type you are merging and fill in the relevant template.
<!--- Check the following box with an x if the following applies: -->
Fix or Feature
<!--- Check the following box with an x if the following applies: -->
Types of Changes
<!--- What types of changes does your code introduce? -->
Migrations and Hooks
<!--- Check the following box with an x if the following applies: -->
on_initializeon_finalizeChecklist for Fix or Feature
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Hotfix
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->
spec_versionhas been incremented.devhas been created.staginghas been created.network-relayer's events have been updated according to the blockchain events if applicable.Checklist for Release
<!--- All boxes need to be checked. Follow this checklist before requiring PR review -->